From 33d3407694c9dece0f3e59aa577eda98c9384ea1 Mon Sep 17 00:00:00 2001
From: Ulyssa <git@ulyssa.dev>
Date: Thu, 5 Jun 2025 19:46:32 -0700
Subject: [PATCH] Apply user highlighting to display name changes (#449)

---
 src/message/html.rs  |  6 +++++
 src/message/state.rs | 54 +++++++++++++++++++++++++++-----------------
 2 files changed, 39 insertions(+), 21 deletions(-)

diff --git a/src/message/html.rs b/src/message/html.rs
index 5ba9830..82aac65 100644
--- a/src/message/html.rs
+++ b/src/message/html.rs
@@ -284,6 +284,7 @@ pub enum StyleTreeNode {
     RoomAlias(OwnedRoomAliasId),
     RoomId(OwnedRoomId),
     UserId(OwnedUserId),
+    DisplayName(String, OwnedUserId),
 }
 
 impl StyleTreeNode {
@@ -333,6 +334,7 @@ impl StyleTreeNode {
             StyleTreeNode::UserId(_) => {},
             StyleTreeNode::RoomId(_) => {},
             StyleTreeNode::RoomAlias(_) => {},
+            StyleTreeNode::DisplayName(_, _) => {},
         }
     }
 
@@ -472,6 +474,10 @@ impl StyleTreeNode {
                 let style = printer.settings().get_user_style(user_id);
                 printer.push_str(user_id.as_str(), style);
             },
+            StyleTreeNode::DisplayName(display_name, user_id) => {
+                let style = printer.settings().get_user_style(user_id);
+                printer.push_str(display_name.as_str(), style);
+            },
             StyleTreeNode::RoomId(room_id) => {
                 let bold = style.add_modifier(StyleModifier::BOLD);
                 printer.push_str(room_id.as_str(), bold);
diff --git a/src/message/state.rs b/src/message/state.rs
index 8f19f0c..53885c4 100644
--- a/src/message/state.rs
+++ b/src/message/state.rs
@@ -242,10 +242,7 @@ pub fn body_cow_state(ev: &AnySyncStateEvent) -> Cow<'static, str> {
                                     format!("* set their display name to {:?}", new)
                                 },
                                 (Some(old), Some(new)) => {
-                                    format!(
-                                        "* changed their display name from {:?} to {:?}",
-                                        old, new
-                                    )
+                                    format!("* changed their display name from {old} to {new}")
                                 },
                                 (Some(_), None) => "* unset their display name".to_string(),
                                 (None, None) => {
@@ -600,7 +597,7 @@ pub fn html_state(ev: &AnySyncStateEvent) -> StyleTree {
 
             let prev_details = prev_content.as_ref().map(|p| p.details());
             let change = content.membership_change(prev_details, ev.sender(), &state_key);
-            let user_id = StyleTreeNode::UserId(state_key);
+            let user_id = StyleTreeNode::UserId(state_key.clone());
 
             match change {
                 MembershipChange::None => {
@@ -673,44 +670,59 @@ pub fn html_state(ev: &AnySyncStateEvent) -> StyleTree {
                     vec![prefix, user_id]
                 },
                 MembershipChange::ProfileChanged { displayname_change, avatar_url_change } => {
-                    let m = match (displayname_change, avatar_url_change) {
+                    match (displayname_change, avatar_url_change) {
                         (Some(change), avatar_change) => {
                             let mut m = match (change.old, change.new) {
                                 (None, Some(new)) => {
-                                    format!("* set their display name to {:?}", new)
+                                    vec![
+                                        StyleTreeNode::Text("* set their display name to ".into()),
+                                        StyleTreeNode::DisplayName(new.into(), state_key),
+                                    ]
                                 },
                                 (Some(old), Some(new)) => {
-                                    format!(
-                                        "* changed their display name from {:?} to {:?}",
-                                        old, new
-                                    )
+                                    vec![
+                                        StyleTreeNode::Text(
+                                            "* changed their display name from ".into(),
+                                        ),
+                                        StyleTreeNode::DisplayName(old.into(), state_key.clone()),
+                                        StyleTreeNode::Text(" to ".into()),
+                                        StyleTreeNode::DisplayName(new.into(), state_key),
+                                    ]
+                                },
+                                (Some(_), None) => {
+                                    vec![StyleTreeNode::Text("* unset their display name".into())]
                                 },
-                                (Some(_), None) => "* unset their display name".to_string(),
                                 (None, None) => {
-                                    "* made an unknown change to their display name".to_string()
+                                    vec![StyleTreeNode::Text(
+                                        "* made an unknown change to their display name".into(),
+                                    )]
                                 },
                             };
 
                             if avatar_change.is_some() {
-                                m.push_str(" and changed their user avatar");
+                                m.push(StyleTreeNode::Text(
+                                    " and changed their user avatar".into(),
+                                ));
                             }
 
-                            Cow::Owned(m)
+                            m
                         },
                         (None, Some(change)) => {
-                            match (change.old, change.new) {
+                            let m = match (change.old, change.new) {
                                 (None, Some(_)) => Cow::Borrowed("* added a user avatar"),
                                 (Some(_), Some(_)) => Cow::Borrowed("* changed their user avatar"),
                                 (Some(_), None) => Cow::Borrowed("* removed their user avatar"),
                                 (None, None) => {
                                     Cow::Borrowed("* made an unknown change to their user avatar")
                                 },
-                            }
-                        },
-                        (None, None) => Cow::Borrowed("* changed their user profile"),
-                    };
+                            };
 
-                    vec![StyleTreeNode::Text(m)]
+                            vec![StyleTreeNode::Text(m)]
+                        },
+                        (None, None) => {
+                            vec![StyleTreeNode::Text("* changed their user profile".into())]
+                        },
+                    }
                 },
                 ev => {
                     let prefix =